commit b5bfa111

Poul Sander · 2019-04-16 15:09
b5bfa111107040a9df22bff707c4590593a43f46 patch · browse files
parent d8e16ed8b310bd6f0491320d6cea750b350d8fd1

Improved compiler flags

Changed files

M	CMakeLists.txt before
M	src/Libs/include/rapidxml/rapidxml.hpp before
M	src/saland/console/Console.cpp before

diff --git a/CMakeLists.txt b/CMakeLists.txt index 2fedb35..0503114 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt

@@ -2,7 +2,9 @@ cmake_minimum_required(VERSION 2.8.9)

project (saland)

set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${saland_SOURCE_DIR}/src/cmake")

-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -std=c++11 -g")

+# -Wno-deprecated-declarations is needed until all supported platforms are using PhysFS 3.0.1+.

+# This will happen once Debian 10 is realeased

+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wsuggest-override -Wno-deprecated-declarations -std=c++11 -g")

set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -g")

find_package(Boost COMPONENTS program_options REQUIRED)

diff --git a/src/Libs/include/rapidxml/rapidxml.hpp b/src/Libs/include/rapidxml/rapidxml.hpp index 6b82f20..c9fe403 100644 --- a/src/Libs/include/rapidxml/rapidxml.hpp +++ b/src/Libs/include/rapidxml/rapidxml.hpp

@@ -82,7 +82,7 @@ namespace rapidxml

//! Gets human readable description of error.

//! \return Pointer to null terminated description of the error.

- virtual const char *what() const throw()

+ virtual const char *what() const throw() override

{

return m_what;

}

diff --git a/src/saland/console/Console.cpp b/src/saland/console/Console.cpp index 94b7bac..ffb5c26 100644 --- a/src/saland/console/Console.cpp +++ b/src/saland/console/Console.cpp

@@ -55,7 +55,7 @@ struct HelpConsoleCommand : public ConsoleCommand {

return helpMessage;

}

- virtual std::string helpMessage() const { return "Displays this message"; }

+ virtual std::string helpMessage() const override { return "Displays this message"; }

};

static HelpConsoleCommand hcc;